Skip to content

Commit

Permalink
removed useless icon files, fixed boolean repr (#100)
Browse files Browse the repository at this point in the history
closes #78
  • Loading branch information
mattLLVW committed Dec 10, 2019
1 parent 497be6b commit 673f7a6
Show file tree
Hide file tree
Showing 23 changed files with 27 additions and 27 deletions.
7 changes: 7 additions & 0 deletions api/serializers.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,13 @@ class Meta:
model = Minions
fields = "__all__"

def to_representation(self, instance):
data = super(MinionsSerializer, self).to_representation(instance)
data["conformity"] = (
"Unknown" if data["conformity"] is None else str(data["conformity"])
)
return data


class ConformitySerializer(serializers.ModelSerializer):
class Meta:
Expand Down
4 changes: 3 additions & 1 deletion api/views/alcali.py
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,9 @@ def render(self, request):
default_conformity = {
"minion_id": minion.minion_id,
"last_highstate": last_highstate_date,
"conformity": minion.conformity(),
"conformity": "Unknown"
if minion.conformity() is None
else str(minion.conformity()),
"succeeded": succeeded,
"unchanged": unchanged,
"failed": failed,
Expand Down
2 changes: 1 addition & 1 deletion dist/index.html
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<!DOCTYPE html><html lang=en><head><meta charset=utf-8><meta http-equiv=X-UA-Compatible content="IE=edge"><meta name=viewport content="width=device-width,initial-scale=1"><link rel=icon href=/favicon.ico><title>ALCALI</title><link rel=stylesheet href="https://fonts.googleapis.com/css?family=Roboto:100,300,400,500,700,900"><link rel=stylesheet href=https://cdn.jsdelivr.net/npm/@mdi/font@latest/css/materialdesignicons.min.css><link href="https://fonts.googleapis.com/css?family=Material+Icons" rel=stylesheet><link href=/static/css/app.7dd676e0.css rel=preload as=style><link href=/static/css/chunk-vendors.79d99540.css rel=preload as=style><link href=/static/js/app.2911b6e4.js rel=preload as=script><link href=/static/js/chunk-vendors.ff4d722f.js rel=preload as=script><link href=/static/css/chunk-vendors.79d99540.css rel=stylesheet><link href=/static/css/app.7dd676e0.css rel=stylesheet></head><body><noscript><strong>We're sorry but my-app doesn't work properly without JavaScript enabled. Please enable it to continue.</strong></noscript><div id=app></div><script src=/static/js/chunk-vendors.ff4d722f.js></script><script src=/static/js/app.2911b6e4.js></script></body></html>
<!DOCTYPE html><html lang=en><head><meta charset=utf-8><meta http-equiv=X-UA-Compatible content="IE=edge"><meta name=viewport content="width=device-width,initial-scale=1"><link rel=icon href=/favicon.ico><title>ALCALI</title><link rel=stylesheet href="https://fonts.googleapis.com/css?family=Roboto:100,300,400,500,700,900"><link href="https://fonts.googleapis.com/css?family=Material+Icons" rel=stylesheet><link href=/static/css/app.7dd676e0.css rel=preload as=style><link href=/static/css/chunk-vendors.a6f43c83.css rel=preload as=style><link href=/static/js/app.43c2106a.js rel=preload as=script><link href=/static/js/chunk-vendors.90ddc1f0.js rel=preload as=script><link href=/static/css/chunk-vendors.a6f43c83.css rel=stylesheet><link href=/static/css/app.7dd676e0.css rel=stylesheet></head><body><noscript><strong>We're sorry but my-app doesn't work properly without JavaScript enabled. Please enable it to continue.</strong></noscript><div id=app></div><script src=/static/js/chunk-vendors.90ddc1f0.js></script><script src=/static/js/app.43c2106a.js></script></body></html>
1 change: 0 additions & 1 deletion dist/static/css/chunk-vendors.79d99540.css

This file was deleted.

1 change: 1 addition & 0 deletions dist/static/css/chunk-vendors.a6f43c83.css

Large diffs are not rendered by default.

Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
2 changes: 0 additions & 2 deletions dist/static/js/app.2911b6e4.js

This file was deleted.

1 change: 0 additions & 1 deletion dist/static/js/app.2911b6e4.js.map

This file was deleted.

2 changes: 2 additions & 0 deletions dist/static/js/app.43c2106a.js

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions dist/static/js/app.43c2106a.js.map

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

6 changes: 0 additions & 6 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
"xterm-addon-fit": "^0.2.1"
},
"devDependencies": {
"@mdi/font": "^4.0.96",
"@vue/cli-plugin-babel": "^3.12.1",
"@vue/cli-plugin-eslint": "^3.12.1",
"@vue/cli-service": "^3.12.1",
Expand Down
1 change: 0 additions & 1 deletion public/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
<link rel="icon" href="<%= BASE_URL %>favicon.ico">
<title>ALCALI</title>
<link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Roboto:100,300,400,500,700,900">
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/@mdi/font@latest/css/materialdesignicons.min.css">
<link href="https://fonts.googleapis.com/css?family=Material+Icons" rel="stylesheet">
</head>
<body>
Expand Down
6 changes: 3 additions & 3 deletions src/components/ConformityTable.vue
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
{{item.last_highstate === null ? "": new Date(item.last_highstate).toLocaleString("en-GB")}}
</template>
<template v-slot:item.conformity="{ item }">
<v-chip :color="boolRepr(item.conformity)" dark>{{ item.conformity == null ? "unknown": item.conformity.toString() }}
<v-chip :color="boolRepr(item.conformity)" dark>{{ item.conformity }}
</v-chip>
</template>
<template v-slot:item.succeeded="{ item }">
Expand Down Expand Up @@ -121,9 +121,9 @@
})
},
boolRepr(bool) {
if (bool === true) {
if (bool === "True") {
return "green"
} else if (bool === false) {
} else if (bool === "False") {
return "red"
} else return "primary"
},
Expand Down
6 changes: 3 additions & 3 deletions src/components/MinionsTable.vue
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<v-btn text small class="text-none" :to="'/minions/'+item.minion_id">{{ item.minion_id }}</v-btn>
</template>
<template v-slot:item.conformity="{ item }">
<v-chip :color="boolRepr(item.conformity)" dark>{{ item.conformity == null ? "unknown": item.conformity.toString() }}
<v-chip :color="boolRepr(item.conformity)" dark>{{ item.conformity }}
</v-chip>
</template>
<template v-slot:item.last_job="{ item }">
Expand Down Expand Up @@ -157,9 +157,9 @@
})
},
boolRepr(bool) {
if (bool === true) {
if (bool === "True") {
return "green"
} else if (bool === false) {
} else if (bool === "False") {
return "red"
} else return "primary"
},
Expand Down
2 changes: 1 addition & 1 deletion src/components/NotFound.vue
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
</v-card-text>
<v-card-actions>
<v-btn text class="primary darken-3 white--text" to="/">
<v-icon left v-text="'mdi-arrow-left'"/>
<v-icon left>arrow_back</v-icon>
Back
</v-btn>
</v-card-actions>
Expand Down
4 changes: 2 additions & 2 deletions src/components/core/Layout.vue
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@
></v-text-field>
</v-expand-transition>
<v-btn icon @click="expand_search = !expand_search" class="mr-2">
<v-icon>mdi-magnify</v-icon>
<v-icon>search</v-icon>
</v-btn>
<v-menu
v-model="notif_menu"
Expand Down Expand Up @@ -162,7 +162,7 @@
<v-menu bottom left offset-y offset-x close-on-click>
<template v-slot:activator="{ on }">
<v-btn v-on="on" icon>
<v-icon>mdi-dots-vertical</v-icon>
<v-icon>more_vert</v-icon>
</v-btn>
</template>
<v-list>
Expand Down
1 change: 0 additions & 1 deletion src/plugins/vuetify.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import '@mdi/font/css/materialdesignicons.css';
import Vue from 'vue';
import Vuetify, {VSnackbar, VBtn, VIcon} from 'vuetify/lib'

Expand Down

0 comments on commit 673f7a6

Please sign in to comment.