Skip to content

Commit

Permalink
Don't track ip label
Browse files Browse the repository at this point in the history
- Historically, this label has been source of the high cardinality
data.
- This is generally handled at the scraper level where instance or pod
labels are automatically added.
- With support for adding custom labels to every request, users can
add `ip` whenever appropriate, it doesn't need to be done by default.
  • Loading branch information
prathamesh-sonpatki committed May 20, 2024
1 parent edf8550 commit 22275ce
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions src/OpenAPM.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ export type ExtractFromParams = {
export type DefaultLabels =
| 'environment'
| 'program'
| 'ip'
| 'version'
| 'host';

Expand Down Expand Up @@ -187,8 +186,7 @@ export class OpenAPM extends LevitateEvents {
environment: this.environment,
program: packageJson?.name ?? '',
version: packageJson?.version ?? '',
host: os.hostname(),
ip: getHostIpAddress(),
host: os.hostname(),
...this.defaultLabels
};

Expand Down

0 comments on commit 22275ce

Please sign in to comment.