Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python] feat: add keep_in_memory option in serialize_corpora #43

Merged
merged 1 commit into from
Dec 6, 2021
Merged

[python] feat: add keep_in_memory option in serialize_corpora #43

merged 1 commit into from
Dec 6, 2021

Conversation

iron-ij
Copy link
Collaborator

@iron-ij iron-ij commented Dec 5, 2021

@iron-ij
[python] feat: add keep_in_memory option in serialize_corpora
628015f 
-serialize에 keep_in_memory option 추가
seopbo
seopbo approved these changes Dec 6, 2021
View reviewed changes
Copy link
Member

@seopbo seopbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

monologg
monologg approved these changes Dec 6, 2021
View reviewed changes
Copy link
Collaborator

@monologg monologg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:)

@seopbo seopbo merged commit 3c26122 into main Dec 6, 2021
@seopbo seopbo deleted the feature/#42 branch December 6, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seopbo seopbo seopbo approved these changes

@monologg monologg monologg approved these changes

@bzantium bzantium Awaiting requested review from bzantium

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iron-ij @seopbo @monologg