Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin remark-cli to commonjs form #72

Merged
merged 1 commit into from
May 2, 2022
Merged

Conversation

shaunwarman
Copy link
Member

Pinning remark-cli to commonjs form as 10.x.x adds esmodule support and will show the below on new lass projects

> remark . -qfo

README.md
  1:1  error  Error: Cannot parse file `.remarkrc`
Cannot import `node_modules/remark-preset-github/index.js`
Error [ERR_REQUIRE_ESM]: require() of ES Module /Users/shaunwarman/Development/Source/side/xxx/node_modules/to-vfile/index.js from /Users/shaunwarman/Development/Source/side/xxx/node_modules/remark-contributors/index.js not supported.
Instead change the require of /Users/shaunwarman/Development/Source/side/xxx/node_modules/to-vfile/index.js in /Users/shaunwarman/Development/Source/side/xxx/node_modules/remark-contributors/index.js to a dynamic import() which is available in all CommonJS modules

@titanism titanism merged commit 65afd48 into master May 2, 2022
@titanism titanism deleted the commonjs-remark-cli branch May 2, 2022 03:00
@titanism
Copy link
Contributor

titanism commented May 2, 2022

v3.1.1 released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants