Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Youtube playlist search #5

Closed
1 task done
LuciaDX opened this issue Jul 29, 2022 · 2 comments
Closed
1 task done

Youtube playlist search #5

LuciaDX opened this issue Jul 29, 2022 · 2 comments
Assignees
Labels
bug Something isn't working released

Comments

@LuciaDX
Copy link

LuciaDX commented Jul 29, 2022

Describe the bug

If you search youtube playlist that starts with https://www.youtube.com/playlist?... it wont count as playlist

  • play-dl cant search by links you need to pass playlist id instead of full link
  • by searching playlist with playdl.search() it cant get all videos in it but it works with playdl.playlist_info()

Reproduction

Try to add youtube playlist

System Info

Binaries:
    Node: 18.7.0 - /usr/bin/node
    npm: 8.15.0 - /usr/bin/npm
  npmPackages:
    discord-player-plus: ^1.1.1 => 1.1.1
    discord.js: ^14.0.3 => 14.0.3

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
@LuciaDX LuciaDX added the bug Something isn't working label Jul 29, 2022
github-actions bot pushed a commit that referenced this issue Jul 29, 2022
## [1.1.2](v1.1.1...v1.1.2) (2022-07-29)

### Bug Fixes

* **youtube:** unable to search playlist that starts with `https://www.youtube.com/playlist` ([2378c4d](2378c4d)), closes [#5](#5)
@github-actions
Copy link

🎉 This issue has been resolved in version 1.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@larsrickert
Copy link
Owner

larsrickert commented Jul 29, 2022

Hey, thanks for reporting the issue! Its now fixed. It can now search playlists that starts with https://www.youtube.com/watch and https://www.youtube.com/playlist.

Regarding the number of tracks, note the following: YouTube handles /watch and /playlist links a little bit different, e.g.

Both playlist are the same but the second one (/playlist) contains all 236 songs while the first one (/watch) only shows 200 by default. If you click on the last song, it will show the remaining songs and the link changes. If you use the updated link when searching with discord-player-plus all songs will the provided. If using the initial /watch link, you will only get 200 songs like on YouTube. Thats the desired behaviour

@larsrickert larsrickert self-assigned this Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

No branches or pull requests

2 participants