-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try android minSdk 21 #480
Conversation
using api 21 to work all version android
Just setting the declared minSdk to 21 is not enough. The java library actually uses API's which are only available on SDK 26+. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.x #480 +/- ##
============================================
- Coverage 64.27% 64.10% -0.17%
Complexity 282 282
============================================
Files 44 44
Lines 1268 1276 +8
Branches 175 176 +1
============================================
+ Hits 815 818 +3
- Misses 349 355 +6
+ Partials 104 103 -1 ☔ View full report in Codecov by Sentry. |
I tested it on my mother's mobile phone and it worked well. My mother's mobile phone is Android 6 and it executed the sass code well |
Could you add a test case for sdk 21 here:
|
im testing |
It is very strange that my program is at least sdk 21 and it runs the code well, but the actions get errors |
This error is trivial. The library has minSdk 21, but the demo app which is tested has minSdk 26 |
So, the trial program needs to update the SDK? |
@appt2 This is the error I'd expect on sdk 21: https://github.com/larsgrefer/dart-sass-java/actions/runs/8256090593/job/22584005194?pr=480#step:6:308 |
It is strange that your library works well on old mobile phones |
using api 21 to work all version android