Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try android minSdk 21 #480

Merged
merged 9 commits into from
Mar 14, 2024
Merged

Try android minSdk 21 #480

merged 9 commits into from
Mar 14, 2024

Conversation

appt2
Copy link
Contributor

@appt2 appt2 commented Mar 9, 2024

using api 21 to work all version android

using api 21 to work all version android
@larsgrefer
Copy link
Owner

Just setting the declared minSdk to 21 is not enough.

The java library actually uses API's which are only available on SDK 26+.

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 64.10%. Comparing base (c8e929a) to head (3796782).
Report is 50 commits behind head on 3.x.

Files Patch % Lines
...er/sass/embedded/connection/ProcessConnection.java 16.66% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.x     #480      +/-   ##
============================================
- Coverage     64.27%   64.10%   -0.17%     
  Complexity      282      282              
============================================
  Files            44       44              
  Lines          1268     1276       +8     
  Branches        175      176       +1     
============================================
+ Hits            815      818       +3     
- Misses          349      355       +6     
+ Partials        104      103       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@appt2
Copy link
Contributor Author

appt2 commented Mar 12, 2024

Just setting the declared minSdk to 21 is not enough.

The java library actually uses API's which are only available on SDK 26+.

I tested it on my mother's mobile phone and it worked well. My mother's mobile phone is Android 6 and it executed the sass code well

@larsgrefer
Copy link
Owner

Could you add a test case for sdk 21 here:

api-level: [ 26, 30, 34 ]

@appt2
Copy link
Contributor Author

appt2 commented Mar 12, 2024

Could you add a test case for sdk 21 here:

api-level: [ 26, 30, 34 ]

im testing
https://github.com/appt2/dart-sass-java/actions/runs/8254132339

@appt2
Copy link
Contributor Author

appt2 commented Mar 12, 2024

It is very strange that my program is at least sdk 21 and it runs the code well, but the actions get errors
my app

@larsgrefer
Copy link
Owner

This error is trivial. The library has minSdk 21, but the demo app which is tested has minSdk 26

@appt2
Copy link
Contributor Author

appt2 commented Mar 12, 2024

This error is trivial. The library has minSdk 21, but the demo app which is tested has minSdk 26

So, the trial program needs to update the SDK?

@larsgrefer larsgrefer changed the title Update build.gradle Try android minSdk 21 Mar 12, 2024
@larsgrefer
Copy link
Owner

@appt2
Copy link
Contributor Author

appt2 commented Mar 12, 2024

@appt2 This is the error I'd expect on sdk 21: https://github.com/larsgrefer/dart-sass-java/actions/runs/8256090593/job/22584005194?pr=480#step:6:308

It is strange that your library works well on old mobile phones

@larsgrefer larsgrefer merged commit 2c21f93 into larsgrefer:3.x Mar 14, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants