[4.x] Ensure logout requires authentication #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timacdonald
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see: laravel/fortify#536
laravel/ui specific considerations
This only fixes future installations.
We could throw an unauthenticated exception in the controller so that existing installs get this fix, but I don't love that solution as it wouldn't necessarily match what their apps
Authenticatemiddleware does if they have made customisations.Putting the
authmiddleware on the route in the routes file feels problematic as well as the app may not have anauthmiddleware. Everywhere a middleware is currently referenced is published as a stub so the user has full control.This doesn't seems like a massive issue, so I feel this "simple" fix is reasonable.