Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lodash import #247

Merged
merged 3 commits into from
Feb 17, 2023
Merged

Remove lodash import #247

merged 3 commits into from
Feb 17, 2023

Conversation

emargareten
Copy link
Contributor

Lodash was removed from the Laravel skeleton in v10.
There is no usage of lodash in the ui package.

related issue: laravel/framework#46128

@driesvints
Copy link
Member

I'm gonna work on fixing the tests for this package. Bear with me.

@driesvints driesvints marked this pull request as draft February 16, 2023 09:58
@ankurk91
Copy link

Failing tests can be fixed by using php-unit v9

@driesvints driesvints marked this pull request as ready for review February 17, 2023 09:17
@driesvints
Copy link
Member

Thanks @ankurk91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants