[3.x] Replace removeSpecialCharacters method with Str Helper Equivalent #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
voku
added a commit
to voku/portable-ascii
that referenced
this pull request
Feb 8, 2022
-> tests are picked from laravel/ui#219 where the `removeSpecialCharacters` method was replaced with this lib :)
jessarcher
pushed a commit
that referenced
this pull request
Jul 18, 2022
…nt (#219) * Bump support requirment to include new String transliteration helper * Replace removeSpecialCharacters method with Str transliteration method Co-authored-by: Liam Hackett <liamh@DESKTOP-RS5AQ35.localdomain>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update on work for this PR: #216
Now that transliteration exists in Core, I've replaced the existing method in UI with its Str helper equivalent.
Not sure if you also want to bump the other core requirements for consistency sake.