New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check tags after set $this->user() #1236

Merged

taylorotwell merged 1 commit into laravel:4.x from trin4ik:check-tags-after-set-user

Jul 18, 2022

Contributor

trin4ik commented Jul 15, 2022

At now, while u add tags in register method TelescopeServiceProvider.php, like:

Telescope::tag(function (IncomingEntry $entry) {
	$result = [];
	if ($entry->type === EntryType::CLIENT_REQUEST) {
		$result[] = 'http';
		$result[] = 'http:' . $entry->content['response_status'];
		if ($entry->content['response_status'] >= 400) {
			$result[] = 'failed';
		}
	}
	return $result;
});

u cant use $entry->user. its always null.

This PR move parsing-tags-code after set-user-code.


          check tags after set $this->user

d3a331e

taylorotwell merged commit c60ec96 into laravel:4.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet