Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Update to Mix v6 #1039

Merged
merged 2 commits into from
Mar 23, 2021
Merged

[4.x] Update to Mix v6 #1039

merged 2 commits into from
Mar 23, 2021

Conversation

driesvints
Copy link
Member

@driesvints driesvints commented Mar 22, 2021

This updates our build pipeline to Laravel Mix v6. Also bumps several other dependencies. I'll send in a separate PR later on to update Vue to v3.

I needed to remove the copy call from the Laravel Mix file because it was failing for some reason. I also find it a bit out that a directory is created outside this repo. I guess this was for testing purposes?

Closes #1019

@taylorotwell taylorotwell merged commit 90216ca into 4.x Mar 23, 2021
@taylorotwell taylorotwell deleted the update-dependencies branch March 23, 2021 14:54
@tomirons
Copy link
Contributor

tomirons commented Apr 8, 2021

@driesvints with the update to sql-formatter there are now whitespaces where they shouldn't be. You can fix this by setting the language on the formatter to mysql but I'm not sure how it would act with a postgres database.

Here is the new output:

select
  *
from
  ` database `.` table `
where
  ` database `.` table `.` column ` = 1
limit
  1

@tomirons
Copy link
Contributor

tomirons commented Apr 8, 2021

I found the offending commit (sql-formatter-org/sql-formatter@4811f38#diff-58e2b0847926d0ac02995956be8168eb526bb08d921edada1bcbb4e209afce27). Not sure why they did that and I'm not sure what the proper work around should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Mix v6
3 participants