[4.x] fixed frontend request polling memory leaks (#1086)

* fixed frontend request polling memory leaks - fix #1085 * Update IndexScreen.vue * Update IndexScreen.vue Co-authored-by: Taylor Otwell <taylor@laravel.com>
laravel · Jul 6, 2021 · e39ab3b · e39ab3b
1 parent 77373b6
commit e39ab3b
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 10 deletions.
diff --git a/public/app.js b/public/app.js
diff --git a/public/mix-manifest.json b/public/mix-manifest.json
@@ -1,5 +1,5 @@
 {
-    "/app.js": "/app.js?id=c48415fc82fa39a8e52f",
+    "/app.js": "/app.js?id=a8705a256daefb4ab161",
     "/app-dark.css": "/app-dark.css?id=6906f1f2fc2f23cf8a99",
     "/app.css": "/app.css?id=16d2a66165bdfcf0ad02"
 }
diff --git a/resources/js/components/IndexScreen.vue b/resources/js/components/IndexScreen.vue
@@ -136,18 +136,20 @@
                             '&take=1' +
                             '&family_hash=' + this.familyHash
                     ).then(response => {
-                        this.recordingStatus = response.data.status;
+                        if (! this._isDestroyed) {
+                            this.recordingStatus = response.data.status;
 
-                        if (response.data.entries.length && !this.entries.length) {
-                            this.loadNewEntries();
-                        } else if (response.data.entries.length && _.first(response.data.entries).id !== _.first(this.entries).id) {
-                            if (this.$root.autoLoadsNewEntries) {
+                            if (response.data.entries.length && !this.entries.length) {
                                 this.loadNewEntries();
+                            } else if (response.data.entries.length && _.first(response.data.entries).id !== _.first(this.entries).id) {
+                                if (this.$root.autoLoadsNewEntries) {
+                                    this.loadNewEntries();
+                                } else {
+                                    this.hasNewEntries = true;
+                                }
                             } else {
-                                this.hasNewEntries = true;
+                                this.checkForNewEntries();
                             }
-                        } else {
-                            this.checkForNewEntries();
                         }
                     })
                 }, this.newEntriesTimer);