Additional Getter Methods For Retrieving User Information #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeramyhing
changed the title
driesvints
reviewed
Jul 8, 2024
|
Please revert the changes to the interface and mark for review again. Thanks. |
Additional Getter Methods For Retrieving User Information
|
I don't think we need all this for public properties? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
Laravel\Socialite\AbstractUserandLaravel\Socialite\Two\Userclasses to add additional getter methods. It also enhances the existing tests to verify that the new getter methods return the correct property values.Changes
AbstractUserClass UpdatesNew Getter Method:
getAttributes: Get the user's attributes.Two\UserClass Updates:New Getter Methods:
getToken: Retrieves the user's access token.getRefreshToken: Retrieves the user's refresh token.getExpiresIn: Retrieves the number of seconds the access token is valid for.getApprovedScopes: Retrieves the scopes approved by the user during authentication.Tests:
OAuthOneTestandOAuthTwoTestclass to use the new getter methods.Benefits to End Users
These updates provide more convenient methods for retrieving user information, making it easier to work with user data. The changes are backward-compatible and do not break any existing features. Note that while the
Two\Usergetters enhance data retrieval, the properties still require type-hinting for full static analysis compatibility.