[10.x] Fixes usage with sqlsrv databases
#740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@driesvints @mmachatschek Do you mind of reviewing this pull request, and let me know what do you think? |
driesvints
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scout is currently experiencing compatibility issues with Microsoft SQL Server databases, as an error is thrown when attempting to import models on Scout. The error message is as follows:
The regression was introduced in the changes made during the pull request at #509. It happens because two "order by" statements are used with the same column name. While this doesn't pose any problems with other database drivers, it causes issues with Microsoft SQL Server databases, as they do not allow multiple "order by" clauses with the same column name.
Fixes #723.