[9.x] Define conflict with meilisearch-php 0.26.1 #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meilisearch-php 0.26.1 uses a renamed namespace and a renamed Meilisearch\Meiliserach class which break compatilility with Scout
n8man
changed the title
|
Thanks but let's just go for @mmachatschek's PR. I'll do a new release so you're unblocked. |
|
Released v9.7.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MeiliSearch\MeiliSearch class is not found when installing latest meilisearch-php (0.26.1) and latest scout (0.97)
meilisearch/meilisearch-php 0.26.1 renamed its base namespace from
MeiliSearchtoMeilisearchbut also renamed the classMeiliSearch\MeiliSearchclass toMeilisearch\Meilisearch, which breaks compatibility with Scout due to Composer class autoloading being case-sensitive.aThis PR updates the Composer configuration to define a conflict with meilisearch-php >= 0.26.1
I also have a PR on meilisearch-php (meilisearch/meilisearch-php#441) that would reverse the renaming of the class.
I can see that @mmachatschek added some conditional class_exists() calls to work around (#687), but maybe for the time being we should wait to see what is happening with meilisearch-php. I'd be less concerned if meilisearch-php's breaking change had taken place during a transition to v1.0 instead of v0.26.0 -> v0.26.1. That was just weird.