Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Drop old PHP and Laravel versions #675

Merged
merged 3 commits into from
Dec 16, 2022
Merged

Conversation

driesvints
Copy link
Member

@driesvints driesvints commented Dec 15, 2022

Drops support for PHP 7.3 & 7.4 and Laravel 8.x

@driesvints
Copy link
Member Author

@mmachatschek do you know when meilisearch-php v1 hits? Depending on that we might hold off on releasing v10 of Scout until that happens but if it's too far in the future it might not be worth it.

@mmachatschek
Copy link
Contributor

mmachatschek commented Dec 15, 2022

@driesvints the v1 milestone is due 2023-02-06
https://github.com/meilisearch/meilisearch/milestone/37

most sdks are also ready by that time

I suppose most api changes for meilisearch were made with the current v0.30 release and therefore the most recent SDK version would be sufficient I guess.

Maybe @curquiza can add a comment what the major changes for the v1 release for the SDKs would be

Edit: I think its worth dropping all workarounds on the 9.x/10.x branch that were implemented to support most meilisearch versions from >0.19

@driesvints driesvints marked this pull request as draft December 15, 2022 14:50
@driesvints
Copy link
Member Author

Edit: I think its worth dropping all workarounds on the 9.x/10.x branch that were implemented to support most meilisearch versions from >0.19

On 9.x we probably cannot do this but we can on 10.x. Do you maybe want to send in a PR that removes those? You can up the minimum version also to 0.30

@mmachatschek
Copy link
Contributor

On 9.x we probably cannot do this but we can on 10.x. Do you maybe want to send in a PR that removes those? You can up the minimum version also to 0.30

I'll send a PR ASAP (probably tomorrow)

@driesvints
Copy link
Member Author

Thanks @mmachatschek!

@driesvints driesvints marked this pull request as ready for review December 16, 2022 10:25
@driesvints
Copy link
Member Author

@taylorotwell you can merge this one already.

@taylorotwell taylorotwell merged commit 23c87b3 into 10.x Dec 16, 2022
@taylorotwell taylorotwell deleted the deprecate-old-versions branch December 16, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants