[9.x] Fix the sync index settings command not using the scout prefix #670
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
scout:sync-index-settings
command aware of the scout prefix being used.I was able to work around this by assigning the scout prefix to a variable inside the config file, like so:
But I figured the command could be made aware of the prefix instead. This change also allows defining the key as a model, so something like:
Which uses the
searchableAs()
method inside theSearchable
trait, which is already aware of the scout prefix.When a string is passed instead of an FQCN, it will check if it already starts with the prefix before prepending it.