[9.x] Apply limit on DatabaseEngine before applying additional constraints
#621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous PR broke Laravel Nova implementation on Global Search where we use the following:
```php
App\Models\User::search('Laravel')->tap(fn ($query) => $query->limit(5))->get();
```
### Before
Callback using `tap()` take priority over default.
#### After
`limit()` take priority over `tap()` and I would consider this a breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous PR broke Laravel Nova implementation on Global Search where we use the following:
Before
Callback using
tap()take priority over default.After
limit()take priority overtap()and I would consider this a breaking change.