[8.x] Auto identify user #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrooksuk
approved these changes
Jul 31, 2020
nunomaduro
reviewed
Jul 31, 2020
nunomaduro
reviewed
Jul 31, 2020
|
Everything looking good now in Algolia dashboard:
|
|
oh brilliant! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will auto set the user to be identified through Algolia through a config option. Other engines can make use of this new option as well if they want. Turned off by default to avoid breaking changes but I'd recommend to turn this on by default in the next major version.
However: I'm currently not seeing user stats appearing in the dashboard when I test:
Headers are being set properly and all so I don't know what I'm missing here. Need to ping @nunomaduro about it. In draft until this is resolved.
Closes #385