Allow skip of sail checks

[cdarken]

When setting the SKIP_SAIL_CHECKS env variable the docker exec will speed up a bit

[driesvints]

Why?

[powellblyth]

Hi @driesvints
when I looked into this, the primary reason for speed differences (Intel Mac) between docker-compose tasks and sail tasks was the time taken by docker to respond to the docker-compose ps and docker info commands.

If there was a way to reduce these, then sail could become quicker.

I wondered about instead of pre-emptively checking whether docker is running on each command, we could instead try to interpret the failure mode of the command to determine the problem, or move these to a sail check command to speed it up.

[powellblyth]

If there was a way to reduce these, then sail could become quicker.

that only explains half the PR though
EDIT - oops, that comment is invalid, sorry

[cdarken]

@powellblyth what would be the other half?

[powellblyth]

@cdarken Ooops my bad, I think I had a second similar PR on my screen. I'll edit that out. Thanks .

[cdarken]

Why?

About 2x speedup on my machine.
Not something to scowl at, I'd say.

[clytras]

@driesvints you can check again the #191 issue that you were rush to close to see why.

There you and even Taylor himself propose us to create PRs. So this is a PR to address that issue.

That's why there is a reason to keep an issue open, so people to be able to discuss about potential solutions and everybody agree to a solution so when a PR comes-in we won't ask "why" because there was a conversation regarding the problem and people related to the project have come to agree to a solution.

This is a good start to make Sail ~4 seconds faster by disabling docker-compose initial checks that do delay every single sail command on each run.

[driesvints]

@clytras no issue was linked so I had no idea what this was about.

That's why there is a reason to keep an issue open, so people to be able to discuss about potential solutions and everybody agree to a solution so when a PR comes-in we won't ask "why" because there was a conversation regarding the problem and people related to the project have come to agree to a solution.

I appreciate it that you want to provide suggestions here but that's not how we work. Anyone can always send in a PR. Like @cdarken has done here. A closed issue isn't locked either and anyone can still continue to discuss there if they like.

[taylorotwell]

Renamed to SAIL_SKIP_CHECKS so all the Sail related environment variables start with SAIL_.

[clytras]

@driesvints Yes of course. Please don't be offended by my comments; I get blunt sometimes and I wish I've had the time to make a PR but I couldn't even have time to think of an efficient way to address this issue.

I do appreciate from the bottom of my heart all the work that you and Taylor and everyone else that are contributing to this amazing project are doing here and I do want to contribute as well in the future.

Thank you for all the valuable work you're doing for all the community 💪

[driesvints]

@clytras no offence taken. We also appreciate you trying to help out with improving the packages :)