Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share/Expose options and cleanup on exit #168

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Share/Expose options and cleanup on exit #168

merged 1 commit into from
Jun 24, 2021

Conversation

stubbo
Copy link
Contributor

@stubbo stubbo commented Jun 24, 2021

I have started to use the share command and I prefer to use a different server to default.
This PR allows people to set some of the main options in .env so they don't have to add them on the end of the sail share command every time.

I also noticed that the expose container does not get removed when you stop sharing - every time you run the command a new container will be created, to fix this issue I added -rm which will remove the container upon exiting

Example:

Before
sail share --server-host=custom-server.com --domain=domain1.com --subdomain=subdomain --auth=amazing-auth-token
After
SHARE_DASHBOARD=4000
SHARE_SERVER_HOST=custom-server.com
SHARE_TOKEN=amazing-auth-token
sail share --domain=domain1.com --subdomain=subdomain

@taylorotwell taylorotwell merged commit e90b5e7 into laravel:1.x Jun 24, 2021
@stubbo stubbo deleted the patch-1 branch June 24, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants