Replace shutdown handlers with destructors #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunomaduro
requested changes
Sep 21, 2023
| { | ||
| parent::__destruct(); | ||
|
|
||
| if (! empty($this->pid)) { |
There was a problem hiding this comment.
Seems to me, that you want to do if ($this->pid > 0)?
There was a problem hiding this comment.
The destructor can be called before the fork occurs, so this property would not be initialised yet.
isset($this->pid) && $this->pid > 0 would work, but at that point, it's effectively the same as ! empty($this->pid) given that $this->pid is an int.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a memory leak by:
register_shutdown_handlerwith class destructors. (thanks @nunomaduro 🙌)I've also removed redundant calls to restore the cursor and TTY now that the destructor will handle it immediately after each prompt, regardless of whether it's successful or fails due to exception, exit, or
SIGINT/Ctrl+C.Best viewed with "Hide whitespace" enabled.