Remove redundant handling of Symfony-style tags #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessarcher
force-pushed
the
remove-format
branch
from
4ebf1d3
to
43fb10d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was from before we used Symfony's output buffer and was just a crude way to maintain the gray "Provider" and "Tag" labels in the
vendor:publishcommand.The Symfony output buffer was added so that we could track trailing newlines in interleaved output, but it had the added benefit of handling the full range of Symfony formatting tags, making this code redundant.
The changes in #47 allow us to ignore these tags for the purposes of calculating padding, where previously they needed to be converted to escape characters before rendering.