Add view state for scroll prompts #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll need to do a more thorough test and code review, but my first impressions of the UX after checking this out locally are very positive! Well done! 🙌 |
|
@jessarcher mark as ready please when you're ready for me to take a look 👍 |
|
Hey @crazywhalecc! Sorry for the delay. Your scroll behaviour is perfect, but I've refactored the implementation to better fit my mental model. It also removes any state manipulation from the renderers so they can focus purely on rendering. Thanks for your PR and for getting this feature happening! |
jessarcher
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to resolve the issue #42 I created earlier, and this PR completed this feature: you can naturally scroll according to the options displayed on the current page, with minimal cost (perhaps).
As you know, I added a class to store view state, and changed the scroll behavior.
But I only make the virtical scroll naturally. The implementation of the horizontal direction is more complex, and the current plan in the horizontal direction feels tolerable.