Add a --commit option to automatically commit fixes
#233
Conversation
|
Thanks for reviewing @nunomaduro, I really appreciate it! I'm a bit busy today but will fix everything as soon as I can! 🚀 Edit: Making changes incrementally when I have time, I'll mark the PR as ready for review when I'm done :) |
Rename makeCommit to commit Type array key Normalize clean working tree message with Git
caendesilva
force-pushed
the
add-option-to-automatically-commit-fixes
branch
from
de20c9d to
8e87228
Compare
caendesilva
force-pushed
the
add-option-to-automatically-commit-fixes
branch
from
8e87228 to
3d6f3c7
Compare
Example: `1 file changed, 2 insertions(+)` instead of `Changes committed successfully!` laravel#233 (comment)
|
Okay, all issues you brought up should be resolved, along with added tests! |
|
Drafting pending @nunomaduro final review. |
|
@taylorotwell @caendesilva I've reviewed and applied a few changes. Wondering if we should also |
By adding another |
|
Personally don't think we need this flag at the moment. I'm not a big fan of these types of things as they do tend to lead to feature creep. |
@nunomaduro What do you think? I fully understand Taylor's hesitation regarding feature creep, though I would personally argue that the feature is quite light (and could be simplified further), but adds a lot of value as it speeds up workflows even more. |
Abstract
This pull request adds a
--commitoption to the Pint command, making it easy to commit style changes to Git!Development
I tried to match the output formatting and code style to the rest of the codebase, as best I could. The implementation could probably be simplified, instead of using the new action class.
Tests
I have not yet added tests, as I first want to know if this is of interest to the maintainers. When given the go-ahead I'm more than happy to add them.
Screenshots
Success:
Nothing to change:
Error: