[10.x] Cache tokens to prevent unnecessary queries #1368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
reviewed
Oct 19, 2020
| return (new TokenGuard( | ||
| $this->app->make(ResourceServer::class), | ||
| new ResourceServer( |
There was a problem hiding this comment.
This will break apps that are overriding this class.
driesvints
reviewed
Oct 19, 2020
| if ($this->clients->revoked($clientId)) { | ||
| return; | ||
| } | ||
|
|
|
Seems like there are still some fundamental breakages in this PR. Feel free to reattempt it when you've solved them. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #382 by storing the tokens in memory after first retrieval. This is the only direct passport fix as the other queries come from league/oauth2-server and can't be stopped without passing the tokens around like with this.
It also removes the check for revoked client since the server already checks for it.