Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Fix resolveInheritedScopes. #1207

Merged
merged 3 commits into from
Mar 26, 2020
Merged

[8.x] Fix resolveInheritedScopes. #1207

merged 3 commits into from
Mar 26, 2020

Conversation

lucasmichot
Copy link
Contributor

@lucasmichot lucasmichot commented Mar 26, 2020

Previously the first element returns by resolveInheritedScopes was an empty string.
This PR fixes this.

@taylorotwell
Copy link
Member

Do we need a test?

@lucasmichot
Copy link
Contributor Author

I've just added one, just in case: 92f729f

@taylorotwell taylorotwell merged commit 5224dc4 into laravel:8.x Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants