Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong cpus key for libvirt #1898

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Wrong cpus key for libvirt #1898

merged 1 commit into from
Oct 16, 2023

Conversation

ALameLlama
Copy link
Contributor

@ALameLlama ALameLlama commented Oct 9, 2023

Looks like we're trying to set the key cpu_model instead of cpus

https://wiki.openstack.org/wiki/LibvirtXMLCPUModel

In my homestead yaml I have

memory: 2048
cpus: 4

but noticed it wasn't setting the cpus

[root@homestead testing-homestead]# vagrant up
Bringing machine 'testing-homestead' up with 'libvirt' provider...
==> testing-homestead: Checking if box 'laravel/homestead' version '13.0.0' is up to date...
==> testing-homestead: Creating image (snapshot of base box volume).
==> testing-homestead: Creating domain with the following settings...
==> testing-homestead:  -- Name:              testing-homestead
==> testing-homestead:  -- Description:       Source: /home/testing-homestead/Vagrantfile
==> testing-homestead:  -- Domain type:       kvm
==> testing-homestead:  -- Cpus:              1
==> testing-homestead:  -- Feature:           acpi
==> testing-homestead:  -- Feature:           apic
==> testing-homestead:  -- Feature:           pae
==> testing-homestead:  -- Clock offset:      utc
==> testing-homestead:  -- Memory:            2048M

after my change

[root@homestead testing-homestead]# vagrant up
Bringing machine 'testing-homestead' up with 'libvirt' provider...
==> testing-homestead: Checking if box 'laravel/homestead' version '13.0.0' is up to date...
==> testing-homestead: Creating image (snapshot of base box volume).
==> testing-homestead: Creating domain with the following settings...
==> testing-homestead:  -- Name:              testing-homestead
==> testing-homestead:  -- Description:       Source: /home/testing-homestead/Vagrantfile
==> testing-homestead:  -- Domain type:       kvm
==> testing-homestead:  -- Cpus:              4
==> testing-homestead:  -- Feature:           acpi
==> testing-homestead:  -- Feature:           apic
==> testing-homestead:  -- Feature:           pae
==> testing-homestead:  -- Clock offset:      utc
==> testing-homestead:  -- Memory:            2048M

@csaba215
Copy link
Contributor

Nice catch 👍
I used the wrong key. 😞

@svpernova09 svpernova09 merged commit 8346129 into laravel:main Oct 16, 2023
@svpernova09
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants