[5.0] Add dropIfExists() support for SQL Server #8397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SQL Server is currently the only driver lacking dropIfExists() support, giving no warning when it is used. This solution was tested on Windows Server 2012 running SQL Server 2014 and should be compatible with SQL Server going all the way back to v7. The other drivers use `$this->wrapTable($blueprint)` which wraps the table name in double quotes. SQL server choked on this, so I've used `$blueprint->getTable()` instead. Hope that won't be a problem. See [this StackOverflow discussion](http://stackoverflow.com/a/14290099/161752) for more details.
GrahamCampbell
changed the title
taylorotwell
added a commit
that referenced
this pull request
Apr 12, 2015
[5.0] Add dropIfExists() support for SQL Server
|
@akurtz Did the double quotes not work because you had I don't understand the issue with double quotes, considering almost everything wouldn't work with |
|
I think I have guessed. Indeed you had to use refs #13458 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQL Server is currently the only driver lacking dropIfExists() support, giving no warning when it is used. This solution was tested on Windows Server 2012 running SQL Server 2014 and should be compatible with SQL Server going all the way back to v7.
The other drivers use
$this->wrapTable($blueprint)which wraps the table name in double quotes. SQL Server choked on this, so I've used$blueprint->getTable()instead. Hope that won't be a problem.See this StackOverflow discussion for more details.