[11.x] Fix breaking change in RefreshDatabase
#54075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I get the same issue, and this PR fixes it. But why does it happen? It could be related to multiple connections. We use multiple, so we overwrite the method |
|
In our tenancy project we override $connectionsToTransact and we include null in the array. protected array $connectionsToTransact = [null, 'tenant'];I suspect it's this null value causing some pain for people using it in this way. This was related to archtechx/tenancy specifically, but I suspect others have similar issues. Can confirm this will fix it. Thank you all for taking care of this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a breaking chance introduced by #53997, as reported by this comment.
I haven't been able to reproduce it, but sometimes
$connection->getPdo()can benull.Also, you've asked if it was possible to test the changes in the original PR. I've tried, but I haven't been able to come up with a meaningful way to unit test this.