[11.x] Add PHPDoc type hints #53984
Merged
[11.x] Add PHPDoc type hints #53984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timacdonald
reviewed
Dec 19, 2024
Comment on lines
-76
to
+77
| * @method static \Illuminate\Console\Scheduling\PendingEventAttributes monthlyOn(int $dayOfMonth = 1, string $time = '0:0') | ||
| * @method static \Illuminate\Console\Scheduling\PendingEventAttributes twiceMonthly(int $first = 1, int $second = 16, string $time = '0:0') | ||
| * @method static \Illuminate\Console\Scheduling\PendingEventAttributes monthlyOn(int<0, 31> $dayOfMonth = 1, string $time = '0:0') | ||
| * @method static \Illuminate\Console\Scheduling\PendingEventAttributes twiceMonthly(int<0, 31> $first = 1, int<0, 31> $second = 16, string $time = '0:0') |
There was a problem hiding this comment.
If this is a zero based month index, should the range be 1-31? Or does 0 do something special here?
There was a problem hiding this comment.
Damn, you are right 👍🏻 My bad 🤦🏻 😅
simon-tma
added a commit
to simon-tma/framework
that referenced
this pull request
Jan 2, 2025
Fixes the incorrect minutes range introduced in laravel#53984.
taylorotwell
pushed a commit
that referenced
this pull request
Jan 2, 2025
Fixes the incorrect minutes range introduced in #53984.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #53961