-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.x] Fix schema names on DatabaseTruncation
trait (PostgreSQL and SQLServer)
#53787
Merged
taylorotwell
merged 10 commits into
laravel:11.x
from
hafezdivandari:11.x-fix-database-truncation
Dec 10, 2024
Merged
[11.x] Fix schema names on DatabaseTruncation
trait (PostgreSQL and SQLServer)
#53787
taylorotwell
merged 10 commits into
laravel:11.x
from
hafezdivandari:11.x-fix-database-truncation
Dec 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
hafezdivandari
changed the title
[11.x] Fix database truncation on PostgreSQL
[11.x] Fix schema names on Dec 10, 2024
DatabaseTruncation
trait (PostgreSQL and SQLServer)
Hi @hafezdivandari - can you fix the conflict and mark as ready for review? |
Hi @taylorotwell it's ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53745
Unlike
migrate:fresh
,db:wipe
commands, andRefreshDatabase
trait, theDatabaseTruncation
trait does not handle schema names on SQLServer and PostgreSQL and doesn't respectsearch_path
on PostgreSQL.This PR does:
DatabaseTruncation
trait to support schema names (SQLServer and PostgreSQL).DatabaseTruncation
trait to respectsearch_path
config of the DB connection (PostgreSQL).prefix
config better onDatabaseTruncation
trait.DatabaseTruncation
trait.Schema::dropAllTables()
,Schema::dropAllViews()
, andSchema::dropAllTypes()
methods on the PostgreSQL schema builder: No need to escape schema names when comparing values, becauseSchema::getSchemas()
andSchema::getTables()
return unescaped values.Example
Refer to
DatabaseTruncation
docs.You can also define these properties based on connection names:
Note:
migrations
table (on all schemas) is always ignored, and never get truncated using this trait.