[11.x] Support DB aggregate by group (new methods) #53679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
commented
Nov 27, 2024
| $sql = 'select '; | ||
|
|
||
| if ($query->groups) { | ||
| $sql .= $this->columnize($query->groups).', '; |
There was a problem hiding this comment.
This adds the group columns in the results, even if they are not used.
If a group column is named aggregate, the DB engine will prefix it with the table name. We don't have conflict with the calculated aggregate.
There was a problem hiding this comment.
I have fear this is going to be another breaking change 😅 any way we can be sure?
There was a problem hiding this comment.
This doesn't affect queries created by the query builder. The result of the aggregate functions count, max... will stay the same (#53581).
It only add fields to the result when calling the grammar method directly. I moved the new columns last to keep the aggregate result first.
GromNaN
force-pushed
the
group-aggregate
branch
2 times, most recently
from
4bb788d to
bc5ca4b
Compare
4 tasks
GromNaN
force-pushed
the
group-aggregate
branch
from
bc5ca4b to
bd77811
Compare
1 task
crynobone
added a commit
that referenced
this pull request
Jan 14, 2025
This reverts commit 4b9aeae.
taylorotwell
pushed a commit
that referenced
this pull request
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #53209 that have been reverted by #53582.
This new version adds new methods:
countByGroup,minByGroup,maxByGroup,sumByGroupandavgByGroup. I did not create the aliasaverageByGroup, but I can if you believe that's useful.