Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] PHP 8.4 Code Compatibility #53612

Merged
merged 4 commits into from
Nov 21, 2024
Merged

[10.x] PHP 8.4 Code Compatibility #53612

merged 4 commits into from
Nov 21, 2024

Conversation

crynobone
Copy link
Member

No description provided.

crynobone and others added 4 commits November 21, 2024 11:36
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@@ -107,7 +107,7 @@
"nyholm/psr7": "^1.2",
"orchestra/testbench-core": "^8.23.4",
"pda/pheanstalk": "^4.0",
"phpstan/phpstan": "^1.4.7",
"phpstan/phpstan": "~1.11.11",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we no longer releasing feature or bugfixes, we should lock phpstan/phpstan to the version last known to work based on phpstan.src.neon.dist and phpstan.types.neon.dist.

@crynobone crynobone marked this pull request as ready for review November 21, 2024 04:54
@crynobone crynobone mentioned this pull request Nov 21, 2024
5 tasks
@taylorotwell taylorotwell merged commit f4cb362 into 10.x Nov 21, 2024
25 checks passed
@taylorotwell taylorotwell deleted the 10/php84-compat branch November 21, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants