Add the ability to append and prepend middleware priority from the application builder

[ollieread]

This is a follow-up PR for #52897 that adds two methods to the application builder, allowing for easy access to the add middleware after/before methods on the kernel.

Using the examples from the previous PR, the methods would be accessible like so:

return Application::configure(basePath: dirname(__DIR__))
    ->withRouting(
        web: __DIR__.'/../routes/web.php',
        commands: __DIR__.'/../routes/console.php',
        health: '/up',
    )
    ->withMiddleware(function (Middleware $middleware) {
        $middleware->appendToPriorityList(
		    [
		        \Illuminate\Cookie\Middleware\EncryptCookies::class,
		        \Illuminate\Contracts\Auth\Middleware\AuthenticatesRequests::class,
		    ],
		    \Illuminate\Routing\Middleware\ValidateSignature::class
		);

		$middleware->prependToPriorityList(
		    [
		        \Illuminate\Cookie\Middleware\EncryptCookies::class,
		        \Illuminate\Contracts\Auth\Middleware\AuthenticatesRequests::class,
		    ],
		    \Illuminate\Routing\Middleware\ValidateSignature::class
		);
    })
    ->withExceptions(function (Exceptions $exceptions) {
        //
    })->create();

They map as follows:

• Middleware::appendToPriorityList() -> Kernel::addToMiddlewarePriorityAfter()
• Middleware::prependToPriorityList() -> Kernel::addToMiddlewarePriorityBefore()

[taylorotwell]

Can the signature be something like:

$middleware->appendToPriorityList(after: $middlewareToPutTheNewMiddlewareAfter, append: $theMiddlewareToAppend);
$middleware->prependToPriorityList(before: $middlewareToPutTheNewMiddlewareBefore, prepend: $theMiddlewareToPrepend);

Please mark as ready for review when the requested changes have been made.

[taylorotwell]

Hey there! I'm not sure if the parameter names match what I mentioned?

[ollieread]

Hey there! I'm not sure if the parameter names match what I mentioned?

Oh sorry, I had assumed they were just to illustrate as the names are quite long. No worries, I'll update that now.

[ollieread]

Hey there! I'm not sure if the parameter names match what I mentioned?

All done!

[taylorotwell]

Sorry, I mean the actual parameter names, which are here:

[ollieread]

Sorry, I mean the actual parameter names, which are here:

Ah, that makes so much more sense. Sorry, that's on me, my head is all over the place today!

[patrickomeara]

I think this needs tests as I have tried to move my ->priority() call to use this but the priority doesn't change.

Additionally there is an issue with using both as below.

[patrickomeara]

When using both prependToPriorityList() and appendToPriorityList() the $middleware variable is overridden on line 274. getMiddlewarePriorityPrepends() is then called on a string.

[ollieread]

Ah this seems to be a bug either prepending!

[ollieread]

I think this needs tests as I have tried to move my ->priority() call to use this but the priority doesn't change.

Additionally there is an issue with using both as below.

I suspect this is because of the bug you mentioned. I've created a PR fix at #53504