[11.x](feat): Add isPlural method to Pluralizer class #53039
+17
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tal7aouy
changed the title
crynobone
requested changes
Oct 6, 2024
| public function testIsPlural() | ||
| { | ||
| $this->assertTrue(Str::isPlural('children')); | ||
| $this->assertFalse(Str::isPlural('child')); |
There was a problem hiding this comment.
Str class doesn't extends Pluralizer which cause the tests to failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we introduce a new
isPluralmethod to thePluralizerclass. The method determines if a given word is in its plural form by comparing it with its singular form.Changes:
isPluralmethod to check if a word is pluraltrueif the word is plural,falseotherwiseThis addition enhances the functionality of the
Pluralizerclass, providing a simple way to check for plural words.