[4.2] add setter and getter for Validatior #5199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Set is probably the wrong word. Maybe "add", since we're not actually setting the attributes, we adding to them? |
| * @param array $customAttributes | ||
| * @return void | ||
| */ | ||
| public function setCustomAttributes(array $customAttributes) |
There was a problem hiding this comment.
There is already quite similar method called setAttributeNames.
In this case, perhaps the other two method should be called setValueNames and getValueNames?
the getCustomAttributes should be getAttributeNames?
I know your naming makes more sense, but setAttributeNames is already in API.
There was a problem hiding this comment.
@piotr-cz oh, yes. Thank you.
|
Hi, @GrahamCampbell I have fixed the name. Thanks. |
| * @param array $customAttributes | ||
| * @return void | ||
| */ | ||
| public function addCustomAttributes(array $customAttributes) |
There was a problem hiding this comment.
There's already a setAttributeNames method that does almost the same
There was a problem hiding this comment.
@piotr-cz One is 'set', 'add' is another.
taylorotwell
added a commit
that referenced
this pull request
Sep 10, 2014
[4.2] add setter and getter for Validatior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #4037 and #4714