[12.x] Fix the issue of HasMiddleware
compatibility
#51058
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a Tip related to #44516 PR that introduced the
HasMiddleware
interface by @taylorotwell. I always prefer trying the code by myself and when I tried that interface I found no issue when we did not extend theBaseController
but, if we do, we will hit a compatibility issue, therefore, bothBaseController
andHasMiddleware
define the samemiddleware
method name.I love to use an expressive name, so I will suggest other names I think about too that may help
(glueMiddleware, and injectMiddleware)
.Important
The Laravel v.11 users will not feel that issue because every newly created controller does not extend the
BaseController
therefore, they will not hit that compatibility issue (Unless they do).