Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Fix blade tag issue with nested calls 🔧 #45764

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

imanghafoori1
Copy link
Contributor

@imanghafoori1 imanghafoori1 commented Jan 22, 2023

Fixes the reported bug introduced in #45490 (comment)

@rubenvanerk
Copy link

This fixes my issue, thanks!

@GrahamCampbell GrahamCampbell changed the title [9.x] Fix blade tag issue with nested calls. [9.x] Fix blade tag issue with nested calls Jan 22, 2023
@imanghafoori1
Copy link
Contributor Author

imanghafoori1 commented Jan 22, 2023

@taylorotwell
The Blade has never supported using tags within other tag calls. like this: @class( @include())
So the @empty must not get compiled. In fact, the reported issue is treating the @empty() as a raw PHP function call and the @ here is working as a raw PHP operator to suppress the errors.

The syntax highlighting is correct here:

image

@imanghafoori1 imanghafoori1 changed the title [9.x] Fix blade tag issue with nested calls [9.x] Fix blade tag issue with nested calls 🔧 Jan 22, 2023
@taylorotwell taylorotwell merged commit afccc6a into laravel:9.x Jan 23, 2023
@imanghafoori1 imanghafoori1 deleted the blade_nested_call branch January 23, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants