Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Add assert methods for status code 400 and 408 #45701

Closed
wants to merge 1 commit into from

Conversation

WendellAdriel
Copy link
Contributor

This is adding two new assert methods for the response:

$this->assertBadRequest(); // Checks if status code is 400

$this->assertRequestTimeout(); // Checks if status code is 408

@WendellAdriel WendellAdriel changed the title [9.x] Added assert methods for status code 400 and 408 [9.x] Add assert methods for status code 400 and 408 Jan 18, 2023
@taylorotwell
Copy link
Member

Honestly I find it clearer to just assert on the actual status code. 😬

@WendellAdriel
Copy link
Contributor Author

Got it! 😉

I just thought about adding that because in one of the projects I'm working on I was using some calls to assert these codes, but I understand 💪🏼

Thanks for taking some time to look into this either way! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants