Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Ensures channel name matches from start of string #45692

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

timacdonald
Copy link
Member

@timacdonald timacdonald commented Jan 18, 2023

This fixes a bug with the channel matching.

Previously 'customer.order.1' would match the pattern 'order.{id}' because it was not checking that the pattern started at the beginning (^) of the string.

Both of the additional data sets fail with the previous implementation.

@taylorotwell taylorotwell merged commit f7a7a86 into laravel:9.x Jan 18, 2023
@timacdonald timacdonald deleted the matching branch January 18, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants