Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Decouple database component from console component #44798

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

vdauchy
Copy link
Contributor

@vdauchy vdauchy commented Oct 31, 2022

Hi,

I'm using https://github.com/illuminate/database as standalone dependency and since @nunomaduro improved the console output this component have a hard dependency toward https://github.com/illuminate/console (It is impossible to run migrations without it).

There was already some work to handle the absence of output but it does not handle the absence of the View\Components: illuminate/database@8e5c9a3

This PR tryies to decouple furthermore by checking if the View\Components classes exist... Else the callbacks passed as args are executed (this is mandatory as some of them do critical work).

Thanks for your work :-)

@vdauchy vdauchy force-pushed the decoupling-database-from-console branch from 1f1012a to a2d828d Compare October 31, 2022 21:54
@vdauchy vdauchy marked this pull request as ready for review October 31, 2022 22:01
@taylorotwell taylorotwell merged commit e74973c into laravel:9.x Nov 1, 2022
@GrahamCampbell GrahamCampbell changed the title Decouple database component from console component. [9.x] Decouple database component from console component Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants