[9.x] change status code assertions on TestResponseTest. #44661
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Those tests are testing that assertions fail on a non matching status code though? |
Didn't thought that way. My expectation by Might be a personal preference making it a none issue. Thanks @taylorotwell! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello People,
Earlier today I noticed a pull request (#44658) containing a test case I didn't understand. The author copied a test case that was testing another assertion on the TestResponse object. I noticed there were many test cases that were expecting a status code
500 - server errorwhile their assertions expected something else and were passing.This pull request changes the status codes of the test cases and removes redundant exception expectations.