-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[9.x] Prevent error in db/model commands when using unsupported columns #43635
Conversation
@jbrooksuk @joedixon |
5e68c38
to
f8862ba
Compare
Thanks for addressing this @joedixon ! I opened a PR at #43645 for the same issue, so I guess my PR can be closed. There are two things to consider concerning your implementation:
|
Hey @lupinitylabs - thanks for bringing the additional missing mapping to my attention. I've gone ahead and added some more that we were missing support for. I'm not sure it's worth conditionally checking the database type as if it's only an issue with, for instance, MySQL, the other database types won't be impacted anyway. |
Yes, I guess since we are just reading the structure anyways, just mapping it all to string might be fine. |
The PR resolves #43630 #43622
The
doctrine/dbal
package does not support enum types when listing database columns. This PR adds support for mappingenum
andsysname
(issue with some distributions of sqlsrv) tostring
. The Artisandb:show
,db:table
andmodel:show
commands have all been updated to use it.Additonally,
db:show
uses therescue
helper to prevent an error if the engine type is not available. This PR also prevents the error from being reported.