[9.x] Fixes the issue of overriding $wrap property

[mahmoudmohamedramadan]

So, let me explain the issue in more detail:

Laravel says that I can change data keyword via defining a $wrap attribute on the resource class like so,

/**
 * The "data" wrapper that should be applied.
 *
 * @var string|null
 */
 public static $wrap = 'user';

But when I tried this way nothing changed as we can see in the next figure:

---

If this PR gets merged

As we can see in the next figure that this issue has been solved 🎉

[rodrigopedra]

This is a major breaking change. $wrap works fine for individual resources.

An application using $wrap for individual resources (the default behavior) is already expecting unwrapped resource collections when calling its ::collection(...) method.

I am not opposing to you to propose this change, but this should be sent to master instead.

In the meanwhile you can use the docs suggestions on how to wrap resource collections:

If you would like all resource collections to be wrapped in a data key, regardless of their nesting, you should define a resource collection class for each resource and return the collection within a data key.

<?php
 
namespace App\Http\Resources;
 
use Illuminate\Http\Resources\Json\ResourceCollection;
 
class CommentsCollection extends ResourceCollection
{
    /**
     * Transform the resource collection into an array.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return array
     */
    public function toArray($request)
    {
        return ['data' => $this->collection];
    }
}

reference: https://laravel.com/docs/9.x/eloquent-resources#wrapping-nested-resources