[9.x] Restore job id in worker command logs #43305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L3o-pold
force-pushed
the
restore-job-id-in-worker-command-logs
branch
from
87d28b9 to
fa45c61
Compare
|
Maybe this extra info should only be outputted if the verbose level was passed? Alternative might be to do what GitHub do with commit hashes, and only show the first part - the whole thing is long and does someone ruin the cleanliness of the new layout imo. |
|
I'm open to the discussion here, if we agree that we should print it only on verbose level I think it's ok. I just think it's sad to remove it completely. I don't think I am the only user that used this information to debug things prior v9.21.0 . |
|
Yeah this feels like something for verbose mode? Will mark as draft for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restore the job id in worker command log that was removed in #43065.
I think it's important to display the job id for better debugging.
Previous logs looks like:
New log looks like: