[9.x] Arr::map - Fix map-by-reference w/ built-ins #42815
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes fallback support for
map
by-reference with built-in's such asstrrev
that do not accept more than one argument, making it slightly more flexible, predictable and forgiving in behavior, as in the majority of situations the$key
argument is omitted/ignored by the developer anyway.While some situations might remain unsolved for some built-ins (ones that have exactly 2 parameters), I think it's important to mention that in such situations the user would be better off with a different or lower-level method such as
array_map
instead, as Laravel's documentation clearly indicates that a$key
arg is passed within themap
method.Closes #42789