Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Add trashed() method phpDoc for Eloquent factory #42693

Merged
merged 2 commits into from
Jun 7, 2022
Merged

[9.x] Add trashed() method phpDoc for Eloquent factory #42693

merged 2 commits into from
Jun 7, 2022

Conversation

adelf
Copy link
Contributor

@adelf adelf commented Jun 7, 2022

This will improve IDE completion.

@adelf adelf changed the title [9.0] Add trashed() method phpDoc for Eloquent factory [9.x] Add trashed() method phpDoc for Eloquent factory Jun 7, 2022
@taylorotwell taylorotwell merged commit bc4e5ea into laravel:9.x Jun 7, 2022
@jasonmccreary
Copy link
Contributor

Worth noting not every factory has the trashed method.

@adelf
Copy link
Contributor Author

adelf commented Jun 7, 2022

@jasonmccreary agree, but I think it's better to have it in completion...

@jasonmccreary
Copy link
Contributor

Sure. Just putting something out on the webs for the poor developer who might try to use the trashed state (learned via autocompletion) for a model that isn't actually using the SoftDeletes trait. 😅

@adelf adelf deleted the patch-1 branch June 7, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants