Improve type hints in ModelNotFoundException #41068
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am using this class in my unit tests to build up an exception I expect to be thrown in the code under test. My model is using string keys, so both my IDE and static analysis tooling complain about passing its ID. Additional work on this could be done by: - introducing generic types for both the model and its ID - using strong type hints I kept it light and simple for now and only changed the type hints.
|
Thanks for submitting a PR! In order to review and merge PRs most efficiently, we require that all PRs grant maintainer edit access before we review them. For information on how to do this, see the relevant GitHub documentation. |
|
I would love to grant edit access to the PR, but apparently it is not possible yet for organization repositories - see isaacs/github#1681 |
|
Please re-create this PR from your personal account. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using this class in my unit tests to build up an exception I expect
to be thrown in the code under test. My model is using string keys, so
both my IDE and static analysis tooling complain about passing its ID.
Additional work on this could be done by introducing generic types for both the model and its ID. However, this would most likely require moving the hydration of the exception into
__construct()and thus breaking the interface. I kept it light and simple for now and only changed the type hints.