[9.x] Fix default pivot attributes #40947
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix an issue, when a custom pivot model is being used with default attributes. Related PR: #18127
Let's say I have the same pivot setup as the linked PR, but also, my pivot has default attributes:
It works well, when just creating a new instance:
But fails when creating a new pivot via the relation instance, it just simply overrides the default attributes that are defined in the pivot model's
$attributes
property:In my opinion, this is a bug, because if I want the default attributes to be empty, then I won't define them, but if they are defined, then they should be present in a fresh pivot instance.
Casting should be working as before, and I think this is not a BC.